Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loose up a bit on what happens when build error report on us errors o… #12059

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

heejaechang
Copy link
Contributor

@heejaechang heejaechang commented Jun 16, 2016

…n a file that doesn't exist in roslyn solution but have error code we own.

we used to treat them as project level errors but that made us to sometime show one entry for multiple error reports.

now, we will at least show all of them, but things like double click will not work since we don't know which document it is.

…n a file that doesn't exist in roslyn solution

but have error code we own.

we used to treat them as project level errors but that made us to sometime show one entry for multiple error reports.

now, we will at least show all of them, but things like double click will not work since we don't know which document it is.
@heejaechang
Copy link
Contributor Author

related issue
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/93786?fullScreen=false

and
https://devdiv.visualstudio.com/web/wi.aspx?pcguid=011b8bdf-6d56-4f87-be0d-0092136884d9&id=205144

I believe real fix should be done by xaml (not giving us file that doesnt exist in our solution from build). I am already talking with them on the issue.

@heejaechang
Copy link
Contributor Author

can you code review @srivatsn @mavasani

@mavasani
Copy link
Contributor

👍

1 similar comment
@srivatsn
Copy link
Contributor

👍

@heejaechang
Copy link
Contributor Author

retest windows_eta_open_prtest please

@heejaechang heejaechang merged commit fa78c0e into dotnet:master Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants